Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procedures: Add readiness init container docs #2139

Merged
merged 37 commits into from
Nov 26, 2021
Merged

procedures: Add readiness init container docs #2139

merged 37 commits into from
Nov 26, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Oct 18, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this pull request change?

What issues does this pull request fix or reference?

eclipse-che/che#20337

Specify the version of the product this pull request applies to

7.38 and above

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@mmorhun mmorhun requested review from rkratky, themr0c and a team as code owners October 18, 2021 13:44
@mmorhun mmorhun self-assigned this Oct 18, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@mmorhun
Add readiness init container docs
1a6bd0b 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@tolusha tolusha mentioned this pull request Oct 19, 2021
Closed
25 tasks
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@tolusha
Copy link
Contributor

tolusha commented Oct 19, 2021

I expect having jq/yq commands to update resources.

@MichalMaler MichalMaler self-assigned this Oct 21, 2021
@MichalMaler MichalMaler added this to the 7.37 milestone Oct 21, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler marked this pull request as draft October 21, 2021 13:08
@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 26, 2021 •
edited
Loading

@tolusha it is not trivial task. There are a few problem here:

  • the env var could be present or not. So we have to handle both cases and there is no ifs or add/change policy.
  • It is not trivial to work in patch with an array if we need to select one by an inner property, not its key
  • the target env var inside CSV cannot be changed with a patch

So, I'd prefer to leave it as is.

@tolusha
Copy link
Contributor

tolusha commented Oct 26, 2021

Ok

@MichalMaler MichalMaler marked this pull request as ready for review October 26, 2021 11:55
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@themr0c themr0c modified the milestones: 7.37, 7.38 Oct 28, 2021
@MichalMaler
MMaler edits
357fec3 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@mmorhun
Fixes
5acb202 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@themr0c themr0c changed the title Add readiness init container docs docs: Add readiness init container docs Nov 24, 2021
@themr0c themr0c changed the title docs: Add readiness init container docs procedures: Add readiness init container docs Nov 24, 2021
@mmorhun
Fix message
f94f272 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
Merge branch 'master' into che-20337
1cf617b
@mmorhun @max-cx
Update modules/administration-guide/partials/assembly_enabling-and-di…
15977a1 
…sabling-readiness-init-containers-for-the-olm-installer.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
@mmorhun @max-cx
Apply suggestions from code review
561930e 
Co-authored-by: Max Leonov <mleonov@redhat.com>
@mmorhun @max-cx
Apply suggestions from code review
9cc3571 
Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
max-cx approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language and modular docs reviewed.

@themr0c
Copy link
Contributor

themr0c commented Nov 26, 2021

eclipsefdn/eca is failing because of a commit by Anonymous (39771996+che-bot@****.noreply). I believe it's fine.

@mmorhun mmorhun merged commit 62ffbe2 into eclipse-che:master Nov 26, 2021
@mmorhun mmorhun deleted the che-20337 branch November 26, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-cx max-cx max-cx approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@themr0c themr0c themr0c approved these changes

@tolusha tolusha Awaiting requested review from tolusha

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

Assignees

@mmorhun mmorhun

@max-cx max-cx

Labels
kind/enhancement
Projects
None yet
Milestone
7.38
Development

Successfully merging this pull request may close these issues.
8 participants
@mmorhun @tolusha @max-cx @themr0c @AndrienkoAleksandr @che-bot @MichalMaler @tstastna